Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: Add readme with CONTRIBUTING.md guidelines#58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
dido18 wants to merge5 commits intomain
base:main
Choose a base branch
Loading
fromadd-readme-contributing

Conversation

@dido18
Copy link
Contributor

Motivation

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged inmain.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

Comment on lines +54 to +56
Arduino Apps bricks might required a docker image, in that case the orchestrator will pull those from the registry configured with the`DOCKER_REGISTRY_BASE` environment variable. By default this points to an Arduino GitHub Container Registry (ghcr.io/arduino).

The only image that needs to be referenced directly is the base Python image (`DOCKER_PYTHON_BASE_IMAGE`), all other containers can be downloaded automatically by the orchestrator depending on the bricks specified as dependencies in the app.yml file.
Copy link
Contributor

@alessio-peruginialessio-peruginiNov 10, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Arduino Apps bricks might required a docker image, in that case theorchestrator will pull those from the registry configured with the`DOCKER_REGISTRY_BASE` environment variable. By default this points to an Arduino GitHub Container Registry (ghcr.io/arduino).
The only image that needs to be referenced directly is the base Python image (`DOCKER_PYTHON_BASE_IMAGE`), all other containers can be downloaded automatically by theorchestrator depending on the bricks specified as dependencies in the app.yml file.
Arduino Apps bricks might required a docker image, in that case thearduino-app-cli will pull those from the registry configured with the`DOCKER_REGISTRY_BASE` environment variable. By default this points to an Arduino GitHub Container Registry (ghcr.io/arduino).
The only image that needs to be referenced directly is the base Python image (`DOCKER_PYTHON_BASE_IMAGE`), all other containers can be downloaded automatically by thearduino-app-cli depending on the bricks specified as dependencies in the app.yml file.

Is it on purpose to reference with the name oforchestrator instead ofarduino-app-cli?

@per1234per1234 added documentationImprovements or additions to documentation enhancementNew feature or request labelsNov 10, 2025
The following development tools must be available in your local environment:

-[Go](https://go.dev/dl/)
-[Taskfile](https://taskfile.dev/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
-[Taskfile](https://taskfile.dev/)
-[Task](https://taskfile.dev/)

The tool's name is "Task"


-[Go](https://go.dev/dl/)
-[Taskfile](https://taskfile.dev/)
-[ddb client]//https://developer.android.com/tools/adb)[optionally]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
-[ddb client]//https://developer.android.com/tools/adb)[optionally]
-[ddb client](https://developer.android.com/tools/adb)[optionally]

Fix markup.

-`task init`

##Uploading the arduino-app-cli into the board
Connect an[Arduino UNO Q](https://www.arduino.cc/product-uno-q) board to the PC via USB.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Connect an[Arduino UNO Q](https://www.arduino.cc/product-uno-q) board to the PC via USB.
Connect an[Arduino UNO Q](https://docs.arduino.cc/hardware/uno-q/) board to the PC via USB.

From experience with the way the Arduino website is maintained, the previous URL is likely to stop working at some point in the future. The documentation pages are the most stable link targets (they typically only break when the URL changes after the product is retired).

##Uploading the arduino-app-cli into the board
Connect an[Arduino UNO Q](https://www.arduino.cc/product-uno-q) board to the PC via USB.

-`task board:install` it installs the current`arduino-app-cli` inside the board (`adb` is needed). The password of the`ardiuno` username of the board is requested.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
-`task board:install`itinstalls the current`arduino-app-cli` insidethe board (`adb` is needed). The password of the`ardiuno` username of the board is requested.
-`task board:install` installs the currentversion of Arduino App CLI onthe board (`adb` is needed). The password of the`arduino` username of the board is requested.
  • Grammar fixes
  • Use official product name
  • Correct username


High quality bug reports and feature requests are valuable contributions to this project. These can be made by submitting an issue report to the project's GitHub repository:

https://github.com/arduino/TODO_REPO_NAME/issues/new/choose

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
https://github.com/arduino/TODO_REPO_NAME/issues/new/choose
https://github.com/arduino/arduino-app-cli/issues/new/choose

@@ -0,0 +1,56 @@
##Environment Variables

The following environment variables are used to configure`arduino-app-cli`:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
The following environment variables are used to configure`arduino-app-cli`:
The following environment variables are used to configureArduino App CLI:

Use official product name.

@@ -1,64 +1,47 @@
#Arduino App CLI
#arduino-app-cli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
#arduino-app-cli
#Arduino App CLI

Use official product name.arduino-app-cli should only be used when referring to the command line invocation.

##License

###Docker Settings
Arduino CLI is licensed under the GPL-3.0 license.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Arduino CLI is licensed under the GPL-3.0 license.
ArduinoAppCLI is licensed under the GPL-3.0 license.

Contributions are welcome!

###Execution Settings
Please read the document[How to contribute] which will show you how to build the source code, run the tests, and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Please read thedocument[How to contribute] which will show you how to build the source code, run the tests, and
Please read the[Contributor Guide] document, which will show you how to build the source code, run the tests, and

See:


The only image that needs to be referenced directly is the base Python image (`DOCKER_PYTHON_BASE_IMAGE`), all other containers can be downloaded automatically by the orchestrator depending on the bricks specified as dependencies in the app.yml file.
[user documentation]:https://github.com/arduino/arduino-app-cli/docs/user-documentation.md
[how to contribute]:https://arduino.github.io/arduino-app-cli/latest/CONTRIBUTING/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
[how to contribute]:https://arduino.github.io/arduino-app-cli/latest/CONTRIBUTING/
[contributor guide]:https://arduino.github.io/arduino-app-cli/latest/CONTRIBUTING/

This accompanies my suggestion above.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@per1234per1234per1234 requested changes

+1 more reviewer

@alessio-peruginialessio-peruginialessio-perugini left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentationImprovements or additions to documentationenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dido18@alessio-perugini@per1234

[8]ページ先頭

©2009-2025 Movatter.jp