arduino/arduino-app-cliPublic

NotificationsYou must be signed in to change notification settings
Fork1
Star5

fix(bricks): overwrite the brick variables of an app#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dido18 merged 20 commits intomainfromfix-bricks-variables

Nov 6, 2025

Merged

fix(bricks): overwrite the brick variables of an app#44

dido18 merged 20 commits intomainfromfix-bricks-variables

Nov 6, 2025

Conversation

Copy link

Contributor

dido18 commentedNov 4, 2025•
edited
Loading

Motivation

Close#43

Affected brick:Arduino Cloud Brick

Change description

Removed a superfluous error returned in the codereturn errors.New("variable default value cannot be empty")

Additional Notes

Added unit tests to avoid regression

Reviewer checklist

PR addresses a single concern.
PR title and description are properly filled.
Changes will be merged inmain.
Changes are covered by tests.
Logging is meaningful in case of troubleshooting.

fix(bricks): overwrite the variables of an app

68ad650

dido18 changed the title~~fix(bricks): overwrite the variables of an app~~fix(bricks): overwrite the brick variables of an app

Nov 4, 2025

dido18 added4 commits

November 4, 2025 17:08

feat(bricks): enhance error messages and add tests for BrickCreate fu…

d1e01fe

…nctionality

feat(tests): update BrickCreate tests and add dummy app configurations

c579998

fix(tests): correct error handling in TestOverrideBrickVariablesOfApp

34b6e0e

fix(go.sum): remove outdated dependencies for kin-openapi and oapi-co…

190f079

…degen

dido18 marked this pull request as ready for review

November 5, 2025 15:06

dido18 requested a review fromlucarin91

November 5, 2025 15:06

per1234 added the bugSomething isn't working label

Nov 5, 2025

lucarin91 reviewed

Nov 5, 2025

View reviewed changes

internal/orchestrator/bricks/bricks.goShow resolvedHide resolved

lucarin91 reviewed

Nov 5, 2025

View reviewed changes

go.modShow resolvedHide resolved

internal/orchestrator/bricks/testdata/my-app.source/python/main.py OutdatedShow resolvedHide resolved

internal/orchestrator/bricks/testdata/my-app.source/app.yaml OutdatedShow resolvedHide resolved

internal/orchestrator/bricks/testdata/dummy-app/app.yaml OutdatedShow resolvedHide resolved

internal/orchestrator/bricks/testdata/my-app.override/app.yaml OutdatedShow resolvedHide resolved

internal/orchestrator/bricks/bricks_test.go OutdatedShow resolvedHide resolved

dido18 requested a review froma team

November 5, 2025 15:30

dido18and others added8 commits

November 5, 2025 16:30

Update internal/orchestrator/bricks/bricks_test.go

d27a951

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update internal/orchestrator/bricks/testdata/my-app.override/app.yaml

d2eefb4

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update internal/orchestrator/bricks/testdata/dummy-app/app.yaml

13e77f0

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update internal/orchestrator/bricks/testdata/my-app.source/app.yaml

d770c4b

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

delete: remove unused override files for my-app

af3b76b

Update main function in main.py to remove empty comment

56124d4

go mod revert

52feffd

fix: reorder import statements in bricks_test.go for consistency

079fdda

lucarin91 reviewed

Nov 5, 2025

View reviewed changes

internal/orchestrator/bricks/testdata/dummy-app/python/main.py OutdatedShow resolvedHide resolved

Update internal/orchestrator/bricks/testdata/dummy-app/python/main.py

9655a60

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

dido18 requested a review fromlucarin91

November 6, 2025 07:19

mirkoCrobu reviewed

Nov 6, 2025

View reviewed changes

internal/orchestrator/bricks/bricks_test.go OutdatedShow resolvedHide resolved

refactor: update test cases for brick creation and variable overrides…

8066017

…; clean up test data

dido18 requested a review frommirkoCrobu

November 6, 2025 08:29

mirkoCrobu approved these changes

Nov 6, 2025

View reviewed changes

lucarin91 approved these changes

Nov 6, 2025

View reviewed changes

internal/orchestrator/bricks/bricks.go OutdatedShow resolvedHide resolved

dido18and others added2 commits

November 6, 2025 10:40

Update internal/orchestrator/bricks/bricks.go

1ada20c

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update internal/orchestrator/bricks/bricks.go

53e7443

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

dido18and others added3 commits

November 6, 2025 10:40

Update internal/orchestrator/bricks/bricks.go

a00c705

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update internal/orchestrator/bricks/bricks.go

e1f746b

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

fix: update error messages in BrickCreate tests for consistency

b06ff39

dido18 merged commit7a63d5f intomain

Nov 6, 2025

6 checks passed

dido18 deleted the fix-bricks-variables branch

November 6, 2025 10:08

Labels

bug

Something isn't working

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(bricks): overwrite the brick variables of an app#44

fix(bricks): overwrite the brick variables of an app#44

Uh oh!

Conversation

dido18 commentedNov 4, 2025•
edited
Loading

Uh oh!

Motivation

Change description

Additional Notes

Reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Movatterモバイル変換

fix(bricks): overwrite the brick variables of an app#44

fix(bricks): overwrite the brick variables of an app#44

Uh oh!

Conversation

dido18 commentedNov 4, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Motivation

Change description

Additional Notes

Reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dido18 commentedNov 4, 2025•
edited
Loading