Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: remove strong requirements in systemd unit#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lucarin91 merged 3 commits intomainfromreduce-app-cli-requirement
Nov 3, 2025

Conversation

@lucarin91
Copy link
Contributor

@lucarin91lucarin91 commentedOct 30, 2025•
edited
Loading

Motivation

Requires in systemd unit is too strict and ties two mucharduino-app-cli wth thearduino-rotuer. So if the router is disabled or stopped, theapp-cli daemon will be too. This is not necessary and creates some strange behavior during system updates.

Change description

Removed requires field.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged inmain.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@per1234per1234 added the bugSomething isn't working labelOct 30, 2025
@lucarin91lucarin91 marked this pull request as ready for reviewOctober 30, 2025 14:06
@lucarin91
Copy link
ContributorAuthor

With some test on the board, I verify that the router is not stopping or disabling the app-cli daemon, as expected.

test start/stop ofarduino-rotuer

  1. sudo systemctl status arduino-app-cli -> running 🟢
  2. sudo systemctl status arduino-router -> running 🟢
  3. sudo systemctl stop arduino-router
  4. sudo systemctl status arduino-router -> dead 🔴
  5. sudo systemctl status arduino-app-cli -> running 🟢

test enable/disable ofarduino-rotuer

  1. sudo systemctl status arduino-app-cli -> enabled 🟢
  2. sudo systemctl status arduino-router -> enabled 🟢
  3. sudo systemctl disable arduino-router
  4. sudo systemctl status arduino-router -> disabled 🟡
  5. sudo systemctl status arduino-app-cli -> enabled 🟢

@lucarin91lucarin91 merged commita6c084e intomainNov 3, 2025
9 checks passed
@lucarin91lucarin91 deleted the reduce-app-cli-requirement branchNovember 3, 2025 17:55
mirkoCrobu pushed a commit that referenced this pull requestNov 4, 2025
* fix: remove strong requirements in systemd unit* trigger ci
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dido18dido18Awaiting requested review from dido18

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucarin91@dido18@per1234
[8]ページ先頭
©2009-2025 Movatter.jp