Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(internal/orchestrator/modelsindex): add unit test for the model list index#22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dido18 merged 7 commits intomainfromtest-models-index
Oct 31, 2025

Conversation

@dido18
Copy link
Contributor

@dido18dido18 commentedOct 24, 2025•
edited
Loading

Motivation

Added unit test for themodel-list.yaml file.

Change description

  • Add the missingModelLabels to the go model

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged inmain.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@dido18
Copy link
ContributorAuthor

check coverage:

cd /home/dido/code/arduino/arduino-app-cli/internal/orchestrator/modelsindex && go test -cover -v -coverprofile=coverage.out  && go tool cover -html=coverage.out

@dido18dido18 marked this pull request as ready for reviewOctober 24, 2025 14:04
@dido18dido18 changed the titletest(models-index): ad unit test for the model list indextest(models-index): add unit test for the model list indexOct 24, 2025
@dido18dido18 changed the titletest(models-index): add unit test for the model list indextest(internal/orchestrator/modelsindex): add unit test for the model list indexOct 24, 2025
@per1234per1234 added the enhancementNew feature or request labelOct 24, 2025
@dido18dido18 merged commitda80048 intomainOct 31, 2025
5 checks passed
@dido18dido18 deleted the test-models-index branchOctober 31, 2025 15:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mirkoCrobumirkoCrobumirkoCrobu approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dido18@mirkoCrobu@per1234
[8]ページ先頭
©2009-2025 Movatter.jp