Commitea06b5e

authored and

committed

fix(app): improve error messages for invalid app paths in Load function

1 parentf61b73f commitea06b5eCopy full SHA for ea06b5e

File tree

+16

-3

lines changed

+16

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func Load(appPath string) (ArduinoApp, error) {`
`48`	`48`	`returnArduinoApp{},fmt.Errorf("app path is not valid: %w",err)`
`49`	`49`	`}`
`50`	`50`	`if!exist {`
`51`		`-returnArduinoApp{},fmt.Errorf("no such file or directory: %s",path)`
	`51`	`+returnArduinoApp{},fmt.Errorf("app path must be a directory: %s",path)`
`52`	`52`	`}`
`53`	`53`	`path,err=path.Abs()`
`54`	`54`	`iferr!=nil {`

Lines changed: 15 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,13 +25,26 @@ import (`
`25`	`25`	`)`
`26`	`26`
`27`	`27`	`funcTestLoad(t*testing.T) {`
`28`		`-t.Run("empty",func(t*testing.T) {`
	`28`	`+t.Run("empty path returns an error",func(t*testing.T) {`
`29`	`29`	`app,err:=Load("")`
`30`	`30`	`assert.Error(t,err)`
`31`	`31`	`assert.Empty(t,app)`
	`32`	`+assert.Contains(t,err.Error(),"empty")`
`32`	`33`	`})`
`33`	`34`
`34`		`-t.Run("AppSimple",func(t*testing.T) {`
	`35`	`+t.Run("it fails if the app path is an existing file",func(t*testing.T) {`
	`36`	`+_,err:=Load("testdata/app.yaml")`
	`37`	`+assert.Error(t,err)`
	`38`	`+assert.Contains(t,err.Error(),"app path must be a directory")`
	`39`	`+})`
	`40`	`+`
	`41`	`+t.Run("it fails if the app path does not exist",func(t*testing.T) {`
	`42`	`+_,err:=Load("testdata/this-folder-does-not-exist")`
	`43`	`+assert.Error(t,err)`
	`44`	`+assert.Contains(t,err.Error(),"app path is not valid")`
	`45`	`+})`
	`46`	`+`
	`47`	`+t.Run("it load an app correctly",func(t*testing.T) {`
`35`	`48`	`app,err:=Load("testdata/AppSimple")`
`36`	`49`	`assert.NoError(t,err)`
`37`	`50`	`assert.NotEmpty(t,app)`

Comments

(0)