Commit9efb92a

committed

fix: improve error handling in AddSketchLibrary by logging warnings for library index update failures

1 parent4ef6145 commit9efb92aCopy full SHA for 9efb92a

File tree

1 file changed

-6

lines changed

internal/orchestrator
- sketch_libs.go

1 file changed

-6

lines changed

`‎internal/orchestrator/sketch_libs.go‎`

Lines changed: 5 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ package orchestrator`
`17`	`17`
`18`	`18`	`import (`
`19`	`19`	`"context"`
`20`		`-"fmt"`
`21`	`20`	`"log/slog"`
`22`	`21`	`"time"`
`23`	`22`
`@@ -48,15 +47,15 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel`
`48`	`47`	`returnnil,err`
`49`	`48`	`}`
`50`	`49`
`51`		`-// update the local library_index if it is older than a certain threshold, to ensure the library is found when added by the arduino-cli`
`52`		`-stream,res:=commands.UpdateLibrariesIndexStreamResponseToCallbackFunction(ctx,func(curr*rpc.DownloadProgress) {`
`53`		`-slog.Debug("downloading library index","progress",curr.Message)`
	`50`	`+stream,_:=commands.UpdateLibrariesIndexStreamResponseToCallbackFunction(ctx,func(curr*rpc.DownloadProgress) {`
	`51`	`+slog.Debug("downloading library index","progress",curr.GetMessage())`
`54`	`52`	`})`
	`53`	`+// update the local library index after a certain time, to avoid if a library is added to the sketch but the local library index is not update, the compile can fail (because the lib is not found)`
`55`	`54`	`req:=&rpc.UpdateLibrariesIndexRequest{Instance:inst,UpdateIfOlderThanSecs:int64(indexUpdateInterval.Seconds())}`
`56`	`55`	`iferr:=srv.UpdateLibrariesIndex(req,stream);err!=nil {`
`57`		`-return []LibraryReleaseID{},fmt.Errorf("error updating library index: %v",err)`
	`56`	`+// ignore the error because a missing connection should not stop the user from adding a library.`
	`57`	`+slog.Warn("error updating library index",slog.String("error",err.Error()))`
`58`	`58`	`}`
`59`		`-slog.Debug("Library index update","status",res().GetLibrariesIndex().GetStatus())`
`60`	`59`
`61`	`60`	`resp,err:=srv.ProfileLibAdd(ctx,&rpc.ProfileLibAddRequest{`
`62`	`61`	`Instance:inst,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9efb92a

File tree

1 file changed

1 file changed

`‎internal/orchestrator/sketch_libs.go‎`

0 commit comments