Commit5a33829

dido18

and

lucarin91

authored

fix: install a library missing from local library-index (#50)

* feat: enhance AddSketchLibrary to update library index and log progress* fix: improve library index update handling in AddSketchLibrary* fix: improve error handling in AddSketchLibrary by logging warnings instead of failing on library index update* fix: extend library index update interval to 60 seconds for improved performance* fix: update library index refresh interval to 10 minutes for improved performance* fix: improve error handling in AddSketchLibrary by logging warnings for library index update failures* Update internal/orchestrator/sketch_libs.goCo-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>* Update internal/orchestrator/sketch_libs.goCo-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>---------Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

1 parentc64fbf6 commit5a33829Copy full SHA for 5a33829

File tree

1 file changed

+14

-0

lines changed

internal/orchestrator
- sketch_libs.go

1 file changed

+14

-0

lines changed

`‎internal/orchestrator/sketch_libs.go‎`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@ package orchestrator`
`17`	`17`
`18`	`18`	`import (`
`19`	`19`	`"context"`
	`20`	`+"log/slog"`
	`21`	`+"time"`
`20`	`22`
`21`	`23`	`"github.com/arduino/arduino-cli/commands"`
`22`	`24`	`rpc"github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"`
`@@ -25,6 +27,8 @@ import (`
`25`	`27`	`"github.com/arduino/arduino-app-cli/internal/orchestrator/app"`
`26`	`28`	`)`
`27`	`29`
	`30`	`+constindexUpdateInterval=10*time.Minute`
	`31`	`+`
`28`	`32`	`funcAddSketchLibrary(ctx context.Context,app app.ArduinoApp,libRefLibraryReleaseID,addDepsbool) ([]LibraryReleaseID,error) {`
`29`	`33`	`srv:=commands.NewArduinoCoreServer()`
`30`	`34`	`varinst*rpc.Instance`
`@@ -43,6 +47,15 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel`
`43`	`47`	`returnnil,err`
`44`	`48`	`}`
`45`	`49`
	`50`	`+stream,_:=commands.UpdateLibrariesIndexStreamResponseToCallbackFunction(ctx,func(curr*rpc.DownloadProgress) {`
	`51`	`+slog.Debug("downloading library index","progress",curr.GetMessage())`
	`52`	`+})`
	`53`	`+// update the local library index after a certain time, to avoid if a library is added to the sketch but the local library index is not update, the compile can fail (because the lib is not found)`
	`54`	`+req:=&rpc.UpdateLibrariesIndexRequest{Instance:inst,UpdateIfOlderThanSecs:int64(indexUpdateInterval.Seconds())}`
	`55`	`+iferr:=srv.UpdateLibrariesIndex(req,stream);err!=nil {`
	`56`	`+slog.Warn("error updating library index, skipping",slog.String("error",err.Error()))`
	`57`	`+}`
	`58`	`+`
`46`	`59`	`resp,err:=srv.ProfileLibAdd(ctx,&rpc.ProfileLibAddRequest{`
`47`	`60`	`Instance:inst,`
`48`	`61`	`SketchPath:app.MainSketchPath.String(),`
`@@ -59,6 +72,7 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel`
`59`	`72`	`iferr!=nil {`
`60`	`73`	`returnnil,err`
`61`	`74`	`}`
	`75`	`+`
`62`	`76`	`returnf.Map(resp.GetAddedLibraries(),rpcProfileLibReferenceToLibReleaseID),nil`
`63`	`77`	`}`
`64`	`78`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5a33829

File tree

1 file changed

1 file changed

`‎internal/orchestrator/sketch_libs.go‎`

0 commit comments