Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Portenta H7: extended pin list, pinNames, SPI, WIre, PWM, ADC#87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

KurtE
Copy link

This is a replacement for PR:#71 and#82.

All of the earlier commits were squashed into one. Then this was converted a few times during the#85 pr time
frame as things kept changing and moving around. It has now been updated to the released .3 version.

I started off adding in the whole pin table as defined by the MBED version, which actually contained duplicate defines. I later reduced this set such that it now longer matches the MBED version, but does still include all of the pins that have external pins on some of the breakout boards. As for compatibility, most of the documentation for these show the PIN names and not numbers, so I imported the MBED Pin name table and have the start of allowing several different operations to be done, like pinMode, digitalWrite.

We defined the additional SPI ports and Wire ports.

We defined an initial setup for Analog pins. Have similar hack to GIGA version for pure Analog. Added additional hacks for duplicated pins. That is two of the analog Pins are the exact same pin as some other digital pins...

Added some PWM support.

Also added WIP: camera support.

mjs513 and facchinm reacted with thumbs up emoji
pillo79and others added5 commitsApril 8, 2025 15:20
Collect all warning messages from the build run and add them to theCI run summary.
Upload the built core archive to an S3 bucket when updating branches inthe main repository.
Github Actions: build and release workflow
pillo79and others added5 commitsApril 8, 2025 17:33
Required by configure-aws-credentials to login to AWS.
'aws s3 sync' expects directories as arguments, but we are uploading asingle file. Use 'aws s3 cp' instead.
This is a replacement for PR:arduino#71 andarduino#82.All of the earlier commits were squashed into one.  Then this was converted a few times during thearduino#85 pr timeframe as things kept changing and moving around.   It has now been updated to the released .3 version.I started off adding in the whole pin table as defined by the MBED version, which actually contained duplicate defines.  I later reducedthis set such that it now longer matches the MBED version, but does still include all of the pins that have external pins on some of thebreakout boards. As for compatibility, most of the documentation for these show the PIN names and not numbers, so I imported theMBED Pin name table and have the start of allowing several different operations to be done, like pinMode, digitalWrite.We defined the additional SPI ports and Wire ports.We defined an initial setup for Analog pins.  Have similar hack to GIGA version for pure Analog.  Added additional hacks for duplicatedpins.  That is two of the analog Pins are the exact same pin as some other digital pins...Added some PWM support.Also added WIP: camera support.Co-Authored-By: Mike S <5366213+mjs513@users.noreply.github.com>
@KurtEKurtEforce-pushed thePortenta_h7_spi_wire_pins_plus_updated branch fromf74016f toc47ea7bCompareApril 8, 2025 19:15
Add PinNames for Giga as well, as I see some of the libraries like touch libraryuses them with MBED to map Pin names to their actual pin
@facchinm
Copy link
Member

👋 me and@pillo79 finally had the time to check the PR and discuss about the possible problems.
To sum up, you are trying to solve the fact that mbed core and one's pin numbering is different and prevents "macros" likePinNameToIndex anddigitalPinToPinName from working.
The proposal we came out with, to avoid dts pollution, would be:

  • fix the libraries we can fix, also because the PinName was often used in sync with mbed specific APIs
  • for the libraries that we can't fix, provide an external "mbed compatibility" library which would hardcode the map between mbed pin number, zephyr pin number and pin names for the supported boards, and provide the missing APIs
  • provide much better defines (like we already do for the C33) for the pins meant to be access "by functionality" (UART1_TX and so on)

About the other changes, we are going to merge them today, thank you so much!

@KurtE
Copy link
Author

👋 me and@pillo79 finally had the time to check the PR and discuss about the possible problems.
To sum up, you are trying to solve the fact that mbed core and one's pin numbering is different and prevents "macros" likePinNameToIndex anddigitalPinToPinName from working.
The proposal we came out with, to avoid dts pollution, would be:
I understand. My main premise for using the pin names is, so much of your documentation and code is geared around it.

For example:
image

@facchinm
Copy link
Member

Yup, the plan is to only have the symbolic name (eg SERIAL0_RTS) by default so cross-boards compatibility will be assured

@KurtE
Copy link
Author

Understood, but at least for me, I would in probably 99% of the time not use this pin for that, more likely I would use
it as pinMode(, OUTPUT); ... in fact I am not sure that pin even has that functionality?

Looking at my Excel document for MUX for that pin, for example I don't even think it has that actual usage.
So I would prefer either the names like you show in the documents and/or pin numbers, but that is just me.

My guess is maybe do both. Can easily do it without additional stuff added to the device tree.
That is once the H7 pin table in the device tree is agreed on, then simply update the PinName table to use those numbers...

Will be great to see what you decide on.

mjs513 reacted with thumbs up emoji

@facchinm
Copy link
Member

Manually merged as#104

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@KurtE@facchinm@pillo79

[8]ページ先頭

©2009-2025 Movatter.jp