arduino/ArduinoCore-zephyrPublic

forked fromzephyrproject-rtos/arduino-core-zephyr

NotificationsYou must be signed in to change notification settings
Fork41
Star160

Changed 'built-in' LED used with Zephir boards from RED to GREEN#265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

bogdanarduino wants to merge2 commits intoarduino:main

base:main

Choose a base branch

frombogdanarduino:built_in_LED_change_to_green

Open

Changed 'built-in' LED used with Zephir boards from RED to GREEN#265

bogdanarduino wants to merge2 commits intoarduino:mainfrombogdanarduino:built_in_LED_change_to_green

Conversation

Copy link

Collaborator

bogdanarduino commentedNov 14, 2025

In ArduinoCore-zephyr\cores\arduino\Arduino.h, the built-in LED index was changed from 0 (RED) to 1 (GREEN).

Changed 'built-in' (default) LED used with Zephir boards from RED to …

b47c37c

…GREEN.

bogdanarduino requested review frompennam andsebromero

November 14, 2025 14:16

pillo79 requested changes

Nov 14, 2025

View reviewed changes

Copy link

pillo79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is changing a global default, which must be available even on boards that only have 1 LED defined.
Please fix this by settingLED_BUILTIN to the appropriate number or macro in each variant (variants/xxx/pins_arduino.h).

Copy link

sebromero commentedNov 17, 2025

@pillo79 @bogdanarduino Maybe instead of changing it in the variant file, it might be cleaner to change it in the device tree overlay? I supposebuiltin-led-gpios can have duplicate entries. So, the first index could always refer to the BUILTIN_LED, while the other entries are for RGB etc. e.g. for Giga it could be:

builtin-led-gpios = <&gpioj 13 GPIO_ACTIVE_LOW> // Green                    <&gpioi 12 GPIO_ACTIVE_LOW>, // Red                    <&gpioj 13 GPIO_ACTIVE_LOW>, // Green                    <&gpioe 3 GPIO_ACTIVE_LOW>; // Blue

Wdyt?

Copy link

Member

facchinm commentedNov 17, 2025

Compeltely agree with@sebromero , the right way to tackle this is via device tree

Reverted change in Arduino.h which affects all boards, and reintroduc…

1afa525

…ed the fix as overlay config instead, for R1, C33 and H7.

Copy link

CollaboratorAuthor

bogdanarduino commentedNov 20, 2025

Thank you all for your feedback! Please recheck the updated fix when you have time.

bogdanarduino requested a review frompillo79

November 20, 2025 13:12

Copy link

pennam commentedNov 27, 2025

Hi@bogdanarduino could you please reword the commits and the PR title to make CI happy ? The pattern is

<scope>: <description>

pennam reviewed

Nov 27, 2025

View reviewed changes

Copy link

pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not a dts expert here, but I'm wondering if there is any specific reason to add a new

/ {zephyr,user {

instead of changing what we already have some lines above

builtin-led-gpios = <&ioport1 7 GPIO_ACTIVE_LOW>,                            <&ioport4 0 GPIO_ACTIVE_LOW>,                            <&ioport8 0 GPIO_ACTIVE_LOW>;