Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork30
board: Add support for UNO Q#210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
DhruvaG2000 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
zephyrCommon: Fixed a bug in the interrupt handler acquisition
Why include this commit as part of a PR for support for UNO Q?
Can it be a separate PR of it's own please?
@pillo79 can you send it as a different PR? (and remove from this branch) |
Take into account the analog switch
Use RBIT intrinsic (if available) instead of the slowsoftware reverse. Note that RBIT is at least ~2x faster:Reverse Function Benchmark==========================Current implementation: 18 msOptimized implementation: 8 msSpeedup: 2.25xSigned-off-by: iabdalkader <i.abdalkader@gmail.com>
The main optimization eliminates the double MODER register write when on=true.Previously: MODER &= ~(0xFFFFFF) then MODER |= pin_bits (two writes)Now: MODER = 0 when off, or MODER = pin_bits when on (single write each)Otherwise, the compiler is already doing a pretty good job.Additional improvements:- Remove unused idxToPin() function (was just returning idx)- Remove unused reverse() function- Use direct pin array access and bit shifts for efficiencySigned-off-by: iabdalkader <i.abdalkader@gmail.com>
this commit can be reverted as soon as the libraries are added to library manager
pillo79 commentedOct 9, 2025
#203 was already opened a few weeks ago, this commit being included was a leftover from all the rebases during the Uno Q release process. Fixed! |
No description provided.