forked fromzephyrproject-rtos/gsoc-2022-arduino-core
Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork30
core: Fix thread section alignment.#209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
iabdalkader wants to merge2 commits intoarduino:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6588cbd toccc56ceCompareThe _static_thread_data struct contains int64_t members that require 8-bytealignment. When placed in a 4-byte aligned section, it causes the linker toinsert padding, which in turn causes __static_thread_data_list_start to pointto the padding not to the first iterable.GNU ld automatically aligns output sections based on the strictest alignmentrequirement of input sections, so moving __static_thread_data_list to its ownsection fixes the problem.Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
ccc56ce to8bdc53eCompareAccording to Zephyr documentation, k_thread_create() both initializesand starts the thread. The second loop that was calling k_thread_start()on each static thread was redundant.Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
8bdc53e to1bab673CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The _static_thread_data struct contains int64_t members that require 8-byte alignment. When placed in a 4-byte aligned section, it causes the linker to insert padding, which in turn causes
__static_thread_data_list_startto point to the padding not to the first iterable.GNU ld automatically aligns output sections based on the strictest alignment requirement of input sections, so moving
__static_thread_data_listto its own section fixes the problem.