forked fromzephyrproject-rtos/gsoc-2022-arduino-core
Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork22
If sketch is not connected to serial - dump serial output#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Current code would hang after a few Serial.print like statements happened when we are not connected tothe Serial monitor.So I put overrides in for the Serial.write(buf, cnt) and Serial.flush()That would first check to see if Serial returns true (DTR)...This appears to match the behavior of the MBED Portenta H8 code.
fe9e040 intoarduino:arduino 15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
facchinm added a commit to facchinm/ArduinoCore-zephyr that referenced this pull requestJun 20, 2025
This would have been spotted if we extend the CI to compile all the exaples (TestClient in particular).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldresolve#35
Tested with Portenta, but should work on all of the others as well.
Current code would hang after a few Serial.print like statements happened when we are not connected to the Serial monitor.
So I put overrides in for the Serial.write(buf, cnt) and Serial.flush() That would first check to see if Serial returns true (DTR)...
This appears to match the behavior of the MBED Portenta H8 code.