Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Slave Wire: fix TwoWire::onService() to handle repeated start#590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
reufer wants to merge1 commit intoarduino:master
base:master
Choose a base branch
Loading
fromreufer:wire-fix

Conversation

@reufer
Copy link

Combined I2C write/read transactions with repeated start
conditions were not possible, since only onRequestCallback was
called. Any previously received data was passed to
onReceiveCallback as part of a subsequent master write.

Combined I2C write/read transactions with repeated startconditions were not possible, since only onRequestCallback wascalled. Any previously received data was passed toonReceiveCallback as part of a subsequent master write.
@stonehippo
Copy link

stonehippo commentedFeb 22, 2021
edited
Loading

@reufer

I don't think this is quite right yet.The existing onService handler in Wire.cpp seems to have a couple of issues (onRequest and onReceive are backwards, and you have to do two writes to get them to the onReceive callback), and your changes don't fully address them. I've taken a pass at rewriting the whole function and I think I've got it working correctly, including handling repeated starts.

Since you've already take a shot at this, would you mind trying out the changes in#605?

@CLAassistant
Copy link

CLAassistant commentedApr 9, 2021
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stonehippo
Copy link

I've submitted#669, which replaces#605 (same code, just applied against current master and resubmitted since the earlier one got stalled due to#616).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reufer@stonehippo@CLAassistant

[8]ページ先頭

©2009-2025 Movatter.jp