Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork218
patch: check for user network interface before reading hostname#984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletionspatches/0244-Add-user-network-interface-check-before-reading-host.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| From 4292f8b7c4aa38b68d22c413f91bdc95192cfad6 Mon Sep 17 00:00:00 2001 | ||
| From: pennam <m.pennasilico@arduino.cc> | ||
| Date: Tue, 29 Oct 2024 11:30:00 +0100 | ||
| Subject: [PATCH] Add user network interface check before reading hostname | ||
| --- | ||
| connectivity/lwipstack/source/LWIPInterface.cpp | 8 +++++--- | ||
| 1 file changed, 5 insertions(+), 3 deletions(-) | ||
| diff --git a/connectivity/lwipstack/source/LWIPInterface.cpp b/connectivity/lwipstack/source/LWIPInterface.cpp | ||
| index 64869a3538..da964543c7 100644 | ||
| --- a/connectivity/lwipstack/source/LWIPInterface.cpp | ||
| +++ b/connectivity/lwipstack/source/LWIPInterface.cpp | ||
| @@ -446,9 +446,11 @@ nsapi_error_t LWIP::add_ethernet_interface(EMAC &emac, bool default_if, OnboardN | ||
| interface->memory_manager = &memory_manager; | ||
| interface->ppp_enabled = false; | ||
| - hostname = user_network_interface->get_hostname(); | ||
| - if (hostname) { | ||
| - netif_set_hostname(&interface->netif, hostname); | ||
| + if (user_network_interface) { | ||
| + hostname = user_network_interface->get_hostname(); | ||
| + if (hostname) { | ||
| + netif_set_hostname(&interface->netif, hostname); | ||
| + } | ||
| } | ||
| #if (MBED_MAC_ADDRESS_SUM != MBED_MAC_ADDR_INTERFACE) | ||
| -- | ||
| 2.45.2 | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.