Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

WiFi Ethernet fix MAC address reversed order#980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pennam merged 7 commits intoarduino:mainfrompennam:MAC-deprecate
Jan 20, 2025

Conversation

@pennam
Copy link
Contributor

MACAddress is deprecated keeping the original reversed behaviour.
uint8_t* macAddress(uint8_t * mac) returns byte aligned withString macAddress()

@JAndrassy
Copy link
Contributor

MACAddress(buff) is legacy Ethernet API, macAddress(buff) is WiFi API.
WiFi API has the MAC bytes reversed in WiFi, WiFi101 and WiFiNINA library (and here in Mbed Core)
Ethernet API never had the MAC address reversed.

so this solution preserves the error in PortnetaEthernet library and for Mbed Core WiFi library this PR changes the behavior of the macAddress function (and the 'tradition' of reversed MAC in WiFi libraries).

so I guess there isn't a good solution for this. I would just remove the reversion completely.

@pennam
Copy link
ContributorAuthor

Ethernet API never had the MAC address reversed.

Thanks@JAndrassy i will doublecheck it, I was assuming it was reversed also in Ethernet library

My goal was primarly to align the behaviour ofmacAddress at least between mbed and renesas core. At this point I suppose is it better to introduce the "reverse tradition" in the renesas WiFi library

@JAndrassy
Copy link
Contributor

JAndrassy commentedOct 25, 2024•
edited
Loading

t this point I suppose is it better to introduce the "reverse tradition" in the renesas WiFi library

we removed it recently for compatibility with esp32, esp8266, rp2040 ...

@pennam
Copy link
ContributorAuthor

we removed it recently

yeah i've disagreed with myself one second after writing this 🙂

I will doublecheck the Ethernet MACAddress behaviour , It feels a bit strange to me that is not reversing the byte order since it is using the same socketWrapper function used in WiFi macAddress but maybe it get twisted one more time before.

@JAndrassy
Copy link
Contributor

I meant Ethernet API in general. the Wiznet Ethernet library, the UIPEtherner etc

@pennam
Copy link
ContributorAuthor

ah ok, got it!

@pennampennam changed the titleWiFi Ethernet deprecate MACAddress(...) in favour of macAddres(...)WiFi Ethernet fix MAC address reversed orderOct 28, 2024
@pennam
Copy link
ContributorAuthor

rebased on latest main to fix ci.

  • WiFi.MACAddress(uint8_t *mac) deprecated since this is Ethernet API
  • MbedSocketClass.macAddress(uint8_t *mac) fixed reversed order

@pennampennam merged commitac359a2 intoarduino:mainJan 20, 2025
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andreagilardoniandreagilardoniandreagilardoni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pennam@JAndrassy@andreagilardoni
[8]ページ先頭
©2009-2025 Movatter.jp