Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: Allow HardwareI2C::requestFrom to return values > 256#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 1 commit intomasterfromi2c-requestFrom-size_t
Dec 10, 2020

Conversation

aentinger
Copy link
Contributor

@aentingeraentinger commentedDec 10, 2020•
edited
Loading

Changing return type ofrequestFrom fromuint8_t tosize_t allows the function to return the correct amount of bytes read (since internally it's already asize_t which is downcast to auint8_t upon returning it).

Merging this PR is a pre-condition for mergingarduino/ArduinoCore-API#132.

@facchinm Let's coordinate to get this done.

facchinm reacted with thumbs up emoji
@github-actions
Copy link

Memory usage change @439eca3

Boardflash%RAM for global variables%
arduino:mbed:envie_m40 - 00.0 - 0.00 - 00.0 - 0.0
arduino:mbed:nano33ble0 - 00.0 - 0.00 - 00.0 - 0.0
Click for full report table
Boardlibraries/Scheduler/examples/MultipleBlinks
flash		%libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		%libraries/doom/examples/Doom
flash		%libraries/doom/examples/Doom
RAM for global variables		%libraries/KernelDebug/examples/KernelDebug
flash		%libraries/KernelDebug/examples/KernelDebug
RAM for global variables		%libraries/Portenta_SDCARD/examples/TestSDCARD
flash		%libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		%libraries/Portenta_Video/examples/Envie_video_coreboot
flash		%libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		%libraries/PDM/examples/PDMSerialPlotter
flash		%libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		%libraries/ThreadDebug/examples/ThreadDebug
flash		%libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		%
arduino:mbed:envie_m400.000.000.000.000.000.000.000.000.000.0
arduino:mbed:nano33ble00.000.000.000.000.000.0
Click for full report CSV
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,0,0.0,0,0.0,0,0.0,0,0.0

…he function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it.
@aentingeraentinger merged commitb97a5db intomasterDec 10, 2020
@aentingeraentinger deleted the i2c-requestFrom-size_t branchDecember 10, 2020 10:08
sebromero pushed a commit to sebromero/ArduinoCore-mbed that referenced this pull requestFeb 2, 2022
…he function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it. (arduino#97)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@aentingeraentinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@aentinger
[8]ページ先頭
©2009-2025 Movatter.jp