Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
RP2040: fix OTA and binary size computation#950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
3 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
12 changes: 0 additions & 12 deletionsmbed-os-to-arduino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletionsmbed-os-to-arduino-macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletionspatches/0235-RP2040-add-second_stage_ota-section-to-linker-script.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| From 9819fef4bdb417e3ff9aee08266264b6ec23e075 Mon Sep 17 00:00:00 2001 | ||
| From: pennam <m.pennasilico@arduino.cc> | ||
| Date: Wed, 11 Sep 2024 12:24:01 +0200 | ||
| Subject: [PATCH 235/236] RP2040: add second_stage_ota section to linker script | ||
| - This was previously done inside mbed-os-to-arduino script | ||
| --- | ||
| .../TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | 4 ++++ | ||
| 1 file changed, 4 insertions(+) | ||
| diff --git a/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld b/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| index ec8bac7e40..8295f3269d 100644 | ||
| --- a/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| +++ b/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| @@ -54,6 +54,10 @@ SECTIONS | ||
| __flash_binary_start = .; | ||
| } > FLASH | ||
| + .second_stage_ota : { | ||
| + KEEP (*(.second_stage_ota)) | ||
| + } > FLASH | ||
| + | ||
| .boot2 : { | ||
| __boot2_start__ = .; | ||
| KEEP (*(.boot2)) | ||
| -- | ||
| 2.45.2 | ||
27 changes: 27 additions & 0 deletionspatches/0236-RP2040-add-simbols-to-linker-script-to-compute-.unin.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| From 35b0d95199cb5b9cda593ce4b4029c4306906ccd Mon Sep 17 00:00:00 2001 | ||
| From: pennam <m.pennasilico@arduino.cc> | ||
| Date: Wed, 11 Sep 2024 12:27:03 +0200 | ||
| Subject: [PATCH 236/236] RP2040: add simbols to linker script to compute | ||
| .uninitialized_data section size | ||
| --- | ||
| .../TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | 2 ++ | ||
| 1 file changed, 2 insertions(+) | ||
| diff --git a/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld b/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| index 8295f3269d..b748bab5fa 100644 | ||
| --- a/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| +++ b/targets/TARGET_RASPBERRYPI/TARGET_RP2040/TOOLCHAIN_GCC_ARM/memmap_default.ld | ||
| @@ -183,7 +183,9 @@ SECTIONS | ||
| .uninitialized_data (COPY): { | ||
| . = ALIGN(4); | ||
| + __uninitialized_data_start__ = .; | ||
| *(.uninitialized_data*) | ||
| + __uninitialized_data_end__ = .; | ||
| } > RAM | ||
| /* Start and end symbols must be word-aligned */ | ||
| -- | ||
| 2.45.2 | ||
2 changes: 1 addition & 1 deletionvariants/NANO_RP2040_CONNECT/conf/mbed_app.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.