Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork218
fix ADC management for pure analog on GIGA#784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CLAassistant commentedDec 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
njadNissi commentedOct 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR allows to fix the management of the pure analogs on GIGA, the issue was that the pure analog pins have not been considered on theg_APinDescription array, this results on miss an offset of 4 elements when ag_AAnalogPinDescription's pin was select in theanalogRead() inwiring_Analog.cpp.
The consequence is that the macros involved in Pin and ADC selection, could potentially identify an ADC assigned to the pure analog pins as the ADC channel for all those analog listed after the pin A11 ing_AAnalogPinDescription array in thevariant.cpp and than read the ADC channel of the pure analog pins instead of the correct one (e. g. A8 for A12, A9 for A13 and so on and so forth).
The Fix split the two kind of analog pin in order that the correct offset is provided during reading time and manage the pure analog and the other analogs pin as a different entities inside the pins management.
This PRfixes#758