Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix ADC management for pure analog on GIGA#784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 1 commit intoarduino:mainfromRocketct:master
Dec 4, 2023

Conversation

@Rocketct
Copy link
Contributor

This PR allows to fix the management of the pure analogs on GIGA, the issue was that the pure analog pins have not been considered on theg_APinDescription array, this results on miss an offset of 4 elements when ag_AAnalogPinDescription's pin was select in theanalogRead() inwiring_Analog.cpp.
The consequence is that the macros involved in Pin and ADC selection, could potentially identify an ADC assigned to the pure analog pins as the ADC channel for all those analog listed after the pin A11 ing_AAnalogPinDescription array in thevariant.cpp and than read the ADC channel of the pure analog pins instead of the correct one (e. g. A8 for A12, A9 for A13 and so on and so forth).

The Fix split the two kind of analog pin in order that the correct offset is provided during reading time and manage the pure analog and the other analogs pin as a different entities inside the pins management.

This PRfixes#758

facchinm reacted with thumbs up emoji
@CLAassistant
Copy link

CLAassistant commentedDec 1, 2023
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facchinmfacchinm merged commitd2867ba intoarduino:mainDec 4, 2023
@njadNissi
Copy link

I have the most updated version of this library in my ArduinoIDE, I checked that all the code is the same. however callinganologRead(A8) or of any of the pureAnalogPins still doesn't work. could you provide an example sketch to show how it should be used?
111
222
333
444

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@facchinmfacchinmAwaiting requested review from facchinm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GIGA R1 - analogRead(A12) returns A8 value

4 participants

@Rocketct@CLAassistant@njadNissi@facchinm

[8]ページ先頭

©2009-2025 Movatter.jp