Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SocketWrapper - copyable networking clients#768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pennam merged 1 commit intoarduino:mainfromJAndrassy:copyable_clients
Feb 5, 2024

Conversation

@JAndrassy
Copy link
Contributor

@JAndrassyJAndrassy commentedNov 21, 2023
edited
Loading

copyable networking clients

it is done the same way as in other LwIP based Arduino networking libraries including the C33 LwipWrapper. There WiFiClient/EthernetClient is a simple copyable class redirecting every method to the object managing the socket. That object is stored in std:shared_ptr.
The PR uses the existing MbedClient as the managing class and adds the copyable class from which then WiFiClent and EthernetClient inherit.

I can't test WiFiSSLSE050Client

@megacct
Copy link
Contributor

Great work, I'm back up and running with my telnet server. I did get a crash when doing a client available() or read() (not sure which) after having called a stop() on the client. Easy workaround in my code and probably shouldn't have been doing that anyway.

@JAndrassyJAndrassy marked this pull request as ready for reviewNovember 23, 2023 19:42
@JAndrassy
Copy link
ContributorAuthor

@facchinm this is important. the networking libraries in this core will not work correctly without this. the copy ability of instanced objects is a feature of the Arduino language. Imagine String would not be copyable in some Core.

@pennampennam self-assigned thisJan 31, 2024
@pennam
Copy link
Contributor

@JAndrassy I think you should rebase this on master sincesetTimeout has been renamed insetSocketTimeout

@JAndrassy
Copy link
ContributorAuthor

@pennam thank you for the reminder. done

Copy link
Contributor

@pennampennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the contribution@JAndrassy

Do you mind also changingsetEccSlot visibility? It must be public.

I'm running a bit of testing on this PR so we can hopefully merge it for the next release.

Copy link
Contributor

@pennampennam left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks

@pennampennam merged commit4b3327e intoarduino:mainFeb 5, 2024
@JAndrassyJAndrassy deleted the copyable_clients branchFebruary 5, 2024 09:30
@JAndrassyJAndrassy mentioned this pull requestFeb 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pennampennampennam approved these changes

Assignees

@pennampennam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JAndrassy@megacct@pennam

[8]ページ先頭

©2009-2025 Movatter.jp