Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve reliability of the Callback implementation#755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 2 commits intoarduino:mainfromalrvid:main
Nov 13, 2023

Conversation

@alrvid
Copy link
Contributor

@alrvidalrvid commentedNov 7, 2023
edited
Loading

These changes are made since some combinations of code and compiler versions sometimes lead to erroneous machine code being generated, because of the somewhat adventurous implementation in Callback.h. The first change prevents the GCC compiler from applying optimizations that assume the code follows strict aliasing rules. The second one prevents the GCC compiler from sometimes generating incorrect inline code for the Callback constructor. The machine code generated with these changes are, on the one hand, less optimal. But on the other hand, the changes should prevent bugs arising from undefined behavior that is tricky to find in the Callback implementation, or simply from compiler bugs in GCC. The philosophy here is that it's better to be safe than sorry, rather than trying to find and fix every single dangerous construct in the code.

See also this post from a few years ago by one of the authors of Callback.h:https://answers.launchpad.net/gcc-arm-embedded/+question/686870

This change prevents the GCC compiler from applying optimizations that assume the code follows strict aliasing rules. In order to prevent bugs arising from undefined behavior that is tricky to find in the Callback implementation, or simply from compiler bugs in GCC. The reason for making the change now is concrete customer cases where incorrect machine code was generated in relation to Mbed Callbacks.
This prevents the GCC compiler from generating incorrect inline code for the Callback constructor.
@alrvidalrvid requested a review fromfacchinmNovember 7, 2023 14:35
@facchinmfacchinm merged commit1a7859c intoarduino:mainNov 13, 2023
@facchinm
Copy link
Member

Ouch, I noticed after merging that the patch will be overridden after the next rebuild of the core... I'll reapply athttps://github.com/arduino/mbed-os and get the patch back in.

facchinm added a commit to arduino/mbed-os that referenced this pull requestNov 13, 2023
facchinm added a commit to arduino/mbed-os that referenced this pull requestNov 13, 2023
facchinm added a commit that referenced this pull requestNov 13, 2023
Importing#755 in the correct tree so it's preserved on rebuild
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@facchinmfacchinmAwaiting requested review from facchinm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alrvid@facchinm

[8]ページ先頭

©2009-2025 Movatter.jp