Make WiFiClientSSL class available#647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

facchinm merged 1 commit intoarduino:mainfromkarlsoderby:karlsoderby/wifi-ssl-fix

Nov 28, 2023

Merged

Make WiFiClientSSL class available#647

facchinm merged 1 commit intoarduino:mainfromkarlsoderby:karlsoderby/wifi-ssl-fix

Nov 28, 2023

Conversation

Copy link

Contributor

karlsoderby commentedMar 23, 2023

WiFiSSLClient was missing inWiFi.h, so examples using SSL fails to compile.

The SSL example was tested with the GIGA R1 WiFi board successfully.

Make SSL class available

410311f

WiFiSSLClient was missing in the WiFi.h file, so examples using SSL fails to compile.

sebromero approved these changes

Apr 6, 2023

View reviewed changes

Copy link

Collaborator

sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link

Collaborator

sebromero commentedApr 6, 2023

@karlsoderby Where is the example sketch that you're referring to?

Copy link

Member

facchinm commentedApr 26, 2023

The issue with this commit is that it brings in ~200KB for every sketch that doesn't want to use SSL.
@sebromero it is targeting boards with 2MB of flash it may or may not be a problem, but the choice at that time was to leave it out.
Maybe adding an example would work?