Ping command#1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pennam merged 4 commits intoarduino:mainfromfabik111:add-ping-command

Feb 5, 2025

Merged

Ping command#1014

pennam merged 4 commits intoarduino:mainfromfabik111:add-ping-command

Feb 5, 2025

Conversation

Copy link

Contributor

fabik111 commentedJan 8, 2025

This PR adds thePing command to SocketHelpers making it available from all the IP network interfaces (WiFi, Ethernet, CatM1...).

The method signature is:

  int ping(const char* hostname, uint8_t ttl = 128);  int ping(const String& hostname, uint8_t ttl = 128);  int ping(IPAddress host, uint8_t ttl = 128);

fabik111and others added3 commits

February 4, 2025 10:33

Add ping command

4cd3c25

patches: add ICMPSocket ping

1ddadbd

Remove ping logic from MbedSocketClass to use ICMPSocket ping

ad2b87d

pennam force-pushed theadd-ping-command branch from1947663 toad2b87dCompare

February 4, 2025 13:42

Copy link

Contributor

pennam commentedFeb 4, 2025

Force pushed to fix conflicts and rebase onmaster. Other changes squashed in the first commit:

Add comments about ttl
Remove RP2040 changes in json file

Added patch with ICMPSocket ping. We need to move ping implementation inside libmbed to avoid adding lwIP include paths to the build. lwIP paths were intentionally removed to avoid clashes in non case sensitive systems.

de1baab

Adapt SocketHelpers ping to use ICMPSocket ping