Moving SDRAM.begin() on Arduino_H7_Video - Artifacts Issue Fix#1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

leonardocavagnis merged 2 commits intoarduino:mainfromJorgetrujilloroman:main

Dec 10, 2024

Merged

Moving SDRAM.begin() on Arduino_H7_Video - Artifacts Issue Fix#1000

leonardocavagnis merged 2 commits intoarduino:mainfromJorgetrujilloroman:main

Dec 10, 2024

Conversation

Copy link

Contributor

Jorgetrujilloroman commentedNov 28, 2024

This PR fixes issues like the reportedhere

Moving SDRAM.begin() on Arduino_H7_Video library

e989613

leonardocavagnis self-assigned this

Nov 28, 2024

leonardocavagnis self-requested a review

December 3, 2024 08:41

leonardocavagnis requested changes

Dec 3, 2024

View reviewed changes

Copy link

Member

leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please@Jorgetrujilloroman apply this fix only on GIGA target

#if defined(ARDUINO_GIGA) /* Configure SDRAM */SDRAM.begin(dsi_getFramebufferEnd()); // Moving this line from line 156 to here solves the artifacts issue#endif...#if !defined(ARDUINO_GIGA)/* Configure SDRAM */SDRAM.begin(dsi_getFramebufferEnd()); //FIXME: SDRAM init after video controller init can cause display glitch at start-up#endif