rename the "HardwareSerial" classes (from the API) with "UART" (from ArduinoCore-avr);
remove functions/definitions from several files in ArduinoCore-avr, since they are already implemented/defined by the API.
Files modified:
- "Arduino.h" : it now includes "api/ArduinoAPI.h" and "api/Common.h"
- "WMath.cpp": few functionalities are already implemented by "api/Common*"
  Files deleted, because included in the API:
- "Client.h"
- "IPAddress*"
- "Print"
- "Server.h"
- "Stream*"
- "Udp.h"
- "WCharacter.h"
- "WString*"
- "binary.h"
port USB, SPI and Wire into API: for all of them types u8/u32 have been replaced with standard types;
the digital* APIs have been adapted;
modification of compile recipes (in "platform.txt") to add the API folder.

giulcioffi added7 commits

Rename HardwareSerial classes with UART

8ac2905

Remove common functions already implemented in API

41794fa

Port USB to API

ca222ce

Move CDC and MSC classes to own files.Fix all u8/u32 entries to stantard types.

Port SPI into API

a6006d1

Port Wire into API

dd6c2c9

Adapt digital* APIs to new signatures

40c3734

Add API folder to compile recipe

e908c9e

bxparks reviewed

Copy link

Contributor

The reason will be displayed to describe this comment to others.Learn more.

Some drive-by comments, because I was curious to see what this was about...

		// Public Methods //////////////////////////////////////////////////////////////

		voidHardwareSerial::begin(unsignedlong baud,byte config)
		voidUartClass::begin(unsignedlong baud,uint16_t config)

Copy link

Contributor

The reason will be displayed to describe this comment to others.Learn more.

Theconfig is later assigned to a*_ucsrc which is declared as auint8_t in UART.h. Was this change intentional?

Copy link

Member

The reason will be displayed to describe this comment to others.Learn more.

This is due tohttps://github.com/arduino/ArduinoCore-API/blob/master/api/HardwareSerial.h#L91 , so the signature must beuint16_t .
Said that, I'll push a commit to fix this by casting the assignment
*_ucsrc = (uint8_t)config; (since we are assured that config fits an uint8_t)

Copy link

Contributor

The reason will be displayed to describe this comment to others.Learn more.

Maybe add a comment to explain why thisusing namespace statement is needed. It us contrary to the usual recommendation of avoidingusing namespace in a C++ header file:https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers

		volatileuint8_t ucsrc,volatileuint8_t udr);
		voidbegin(unsignedlong baud) {begin(baud, SERIAL_8N1); }
		voidbegin(unsignedlong,uint8_t);
		voidbegin(unsignedlong,uint16_t);