Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
fix 6 year old bug in ipaddress.h#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
matthijskooijman commentedNov 16, 2018
I wonder if this would be better fixed by making the declaration in the .h file |
facchinm commentedNov 16, 2018
Fixed byarduino/ArduinoCore-API@3dbd7d7 (as soon as AVR core will be based on chainsaw the patch will be applied here as well) |
aentinger commentedSep 16, 2019
Closing this issue since initial port of ArduinoAPI has been done and this issue is fixed witharduino/ArduinoCore-API@3dbd7d7 as noted by@facchinm . |
NTPClient-based project shrunk per `size firmware.elf` - .text 30100 -> 29838: -262 bytes, -0.8% of Uno Flash - .bss 602 -> 542: -60 bytes, -2.9% of Uno SRAMThat addressesarduino#28,arduino#461,arduino#463 andarduino/Arduino#1007
This bug causes multiple sram usage. Now only one instance should be in sram.
fixarduino/Arduino#1007