Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.1k
avr: platform.txt: sketch_flags, -DPLATFORM={version}#21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Improved baud rate settings formula
matthijskooijman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not so sure about the sketch_flags stuff (and I expect it might raise more discussion, as it ties in with previous discussion about setting sketch-specific options that has of yet been unresolved).
However, adding aPLATFORM version define sounds like a sane thing to do. Especially since the IDE and core versions are no longer tied together since quite some time, checkingARDUINO is no longer effective to check for the presence of certain features of bugfixes in the core.
AddingARDUINO_BOARD andARDUINO_ARCH is probably a good idea, though I wonder if that stuff should really be done in arduino-builder with some "default flags" thing (in which case theARDUINO define and some others should be moved as well), to get some consistency in different cores...
| compiler.elf2hex.cmd=avr-objcopy | ||
| compiler.ldflags= | ||
| compiler.size.cmd=avr-size | ||
| compiler.define=-DARDUINO= -DPLATFORM= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the purpose of this variable? It seems unused?
CLAassistant commentedApr 9, 2021
|
Uh oh!
There was an error while loading.Please reload this page.
platform.txt:
See:arduino/arduino-builder#282