Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

avr: platform.txt: sketch_flags, -DPLATFORM={version}#21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
phd wants to merge3 commits intoarduino:master
base:master
Choose a base branch
Loading
fromphd:phd-platform-txt-a

Conversation

@phd
Copy link

@phdphd commentedJul 26, 2018
edited
Loading

platform.txt:

  • sketch_flags for use with ./platform.sketch.txt
  • define -DPLATFORM= with platform {version}
  • added -DARDUINO_ARCH= and -DARDUINO_BOARD=

See:arduino/arduino-builder#282

@phdphdforce-pushed thephd-platform-txt-a branch fromc830d88 to809234fCompareJuly 26, 2018 17:44
facchinm added a commit that referenced this pull requestOct 19, 2018
Improved baud rate settings formula
Copy link
Collaborator

@matthijskooijmanmatthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not so sure about the sketch_flags stuff (and I expect it might raise more discussion, as it ties in with previous discussion about setting sketch-specific options that has of yet been unresolved).

However, adding aPLATFORM version define sounds like a sane thing to do. Especially since the IDE and core versions are no longer tied together since quite some time, checkingARDUINO is no longer effective to check for the presence of certain features of bugfixes in the core.

AddingARDUINO_BOARD andARDUINO_ARCH is probably a good idea, though I wonder if that stuff should really be done in arduino-builder with some "default flags" thing (in which case theARDUINO define and some others should be moved as well), to get some consistency in different cores...

compiler.elf2hex.cmd=avr-objcopy
compiler.ldflags=
compiler.size.cmd=avr-size
compiler.define=-DARDUINO= -DPLATFORM=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is the purpose of this variable? It seems unused?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let usrecheck it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matthijskooijmanmatthijskooijmanmatthijskooijman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phd@CLAassistant@matthijskooijman

[8]ページ先頭

©2009-2025 Movatter.jp