Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork136
Add SPI bus mode support (controller/peripheral)#257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, I'd just add a comment stating the the "downstream" platforms should add a define (eg.SPI_HAS_PERIPHERAL_MODE) in case they support the functionality
Updated. |
api/HardwareSPI.h Outdated
| SPI_MODE3 =3, | ||
| } SPIMode; | ||
| // Platforms should add a define (eg. SPI_HAS_PERIPHERAL_MODE) if they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's remove theeg to make the define official :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
Signed-off-by: iabdalkader <i.abdalkader@gmail.com>
a07b034 intoarduino:masterUh oh!
There was an error while loading.Please reload this page.
No description provided.