Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added two missing macros to the compatibility pgmspace.h#227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 2 commits intoarduino:masterfromCamelCaseName:master
Nov 28, 2023

Conversation

CamelCaseName
Copy link
Contributor

These two macros were missing so i added them

Some macros were missing from the compatibility header
@CLAassistant
Copy link

CLAassistant commentedNov 26, 2023
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(1cec094) 95.53% compared to head(1036d6c) 95.53%.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #227   +/-   ##=======================================  Coverage   95.53%   95.53%           =======================================  Files          16       16             Lines        1075     1075           =======================================  Hits         1027     1027             Misses         48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@aentinger
Copy link
Contributor

Missing in comparison to ... which other file? In which header file have these macros been previously included?

@CamelCaseName
Copy link
ContributorAuthor

CamelCaseName commentedNov 28, 2023
edited
Loading

They are in the original avr/pgmspace.h included with all Arduino IDE 1.x and 2.x installs for avr boards.

ref:https://www.nongnu.org/avr-libc/user-manual/group__avr__pgmspace.html

@aentinger
Copy link
Contributor

The AVR core doesn't use ArduinoCore-API, however I've tested your change with

  • ArduinoCore-samd ✔️
  • ArduinoCore-mbed ✔️
  • ArduinoCore-megaavr ✔️
  • ArduinoCore-renesas ✔️

and I could not find a regression 👍 .

CamelCaseName reacted with thumbs up emoji

Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@aentingeraentinger merged commit82a5055 intoarduino:masterNov 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aentingeraentingeraentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@CamelCaseName@CLAassistant@codecov-commenter@aentinger

[8]ページ先頭

©2009-2025 Movatter.jp