Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Added two missing macros to the compatibility pgmspace.h#227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Some macros were missing from the compatibility header
Update pgmspace.h
CLAassistant commentedNov 26, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
codecov-commenter commentedNov 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #227 +/- ##======================================= Coverage 95.53% 95.53% ======================================= Files 16 16 Lines 1075 1075 ======================================= Hits 1027 1027 Misses 48 48 ☔ View full report in Codecov by Sentry. |
Missing in comparison to ... which other file? In which header file have these macros been previously included? |
CamelCaseName commentedNov 28, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
They are in the original avr/pgmspace.h included with all Arduino IDE 1.x and 2.x installs for avr boards. ref:https://www.nongnu.org/avr-libc/user-manual/group__avr__pgmspace.html |
The AVR core doesn't use ArduinoCore-API, however I've tested your change with
and I could not find a regression 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
These two macros were missing so i added them