Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix #217 when compiling with newer compiler versions#224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 3 commits intoarduino:masterfromjboynes:can_msg
Nov 6, 2023

Conversation

jboynes
Copy link
Contributor

other.data will never be null, triggering a compilation error with the test cases on GCC-13 or CLang 15.0.0

@codecov-commenter
Copy link

codecov-commenter commentedNov 3, 2023•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(c486627) 95.53% compared to head(8ffd335) 95.53%.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #224   +/-   ##=======================================  Coverage   95.53%   95.53%           =======================================  Files          16       16             Lines        1075     1075           =======================================  Hits         1027     1027             Misses         48       48
FilesCoverage Δ
api/CanMsg.h100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@per1234per1234 added the bug labelNov 3, 2023
Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Small change and we are good to merge.

Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@aentingeraentinger merged commit2c4e96c intoarduino:masterNov 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aentingeraentingeraentinger approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jboynes@codecov-commenter@aentinger@per1234
[8]ページ先頭
©2009-2025 Movatter.jp