Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add documentation for CAN API to fix #221#222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 1 commit intoarduino:masterfromjboynes:can_api
Nov 3, 2023

Conversation

jboynes
Copy link
Contributor

Add documentation to the API methods, to clarify order of message transmission and define other behaviours.

@jboynes
Copy link
ContributorAuthor

Ugh, this failed again due to the API call to upload results. I don't have permissions to redrive this action through the UI so will upload another commit to do so. Rather than a dummy I'd apprecaite any feedback on the wording so I can incorpoarate it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(65633ce) 95.53% compared to head(6a263a1) 95.53%.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #222   +/-   ##=======================================  Coverage   95.53%   95.53%           =======================================  Files          16       16             Lines        1075     1075           =======================================  Hits         1027     1027             Misses         48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@aentingeraentinger merged commitc486627 intoarduino:masterNov 3, 2023
@per1234per1234 linked an issueNov 3, 2023 that may beclosed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aentingeraentingeraentinger approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify CAN frame transmit order
4 participants
@jboynes@codecov-commenter@aentinger@per1234

[8]ページ先頭

©2009-2025 Movatter.jp