Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: do not call "memcpy" if there is a) no data to copy, or b) the src pointer is null.#217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 1 commit intomasterfromfix-wno-null
Sep 27, 2023

Conversation

aentinger
Copy link
Contributor

No description provided.

@aentingeraentinger self-assigned thisSep 26, 2023
@per1234per1234 added bug and removed enhancement labelsSep 27, 2023
@facchinmfacchinm merged commit65633ce intomasterSep 27, 2023
@jboynes
Copy link
Contributor

This PR fails to compile the tests on my desktop, perhaps due to an unhelpfully insightful newer compiler.

% makeConsolidate compiler generated dependencies of target test-ArduinoCore-API[  1%] Building CXX object CMakeFiles/test-ArduinoCore-API.dir/src/CanMsg/test_CanMsg.cpp.oIn file included from .../ArduinoCore-API/test/src/CanMsg/test_CanMsg.cpp:11:.../ArduinoCore-API/test/../api/CanMsg.h:58:36: error: address of array 'other.data' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]    if (this->data_length && other.data)                          ~~ ~~~~~~^~~~.../ArduinoCore-API/test/../api/CanMsg.h:70:38: error: address of array 'other.data' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]      if (this->data_length && other.data)                            ~~ ~~~~~~^~~~2 errors generated.make[2]: *** [CMakeFiles/test-ArduinoCore-API.dir/src/CanMsg/test_CanMsg.cpp.o] Error 1make[1]: *** [CMakeFiles/test-ArduinoCore-API.dir/all] Error 2make: *** [all] Error 2

Compiler:

% c++ --versionApple clang version 15.0.0 (clang-1500.0.40.1)Target: arm64-apple-darwin22.6.0Thread model: posixInstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

jboynes added a commit to jboynes/ArduinoCore-API that referenced this pull requestNov 2, 2023
@aentingeraentinger deleted the fix-wno-null branchNovember 3, 2023 05:37
jboynes added a commit to jboynes/ArduinoCore-API that referenced this pull requestNov 3, 2023
aentinger added a commit that referenced this pull requestNov 6, 2023
Fix#217 when compiling with newer compiler versions
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@facchinmfacchinmAwaiting requested review from facchinm

Assignees

@aentingeraentinger

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aentinger@jboynes@per1234@facchinm
[8]ページ先頭
©2009-2025 Movatter.jp