Have the tests use an implementation ofdtostrf which checks for the largest buffer needed by the String class.
Document the risks of that implementaton and add a TODO not to rely on this function in the production code.

As this no longer uses the deprecated sample implementation, the warning suppression can be removed as it is not compiled.

Remove deprecation diagnostic supppression for dtostrf

fdda28c

Copy link

codecov-commenter commentedSep 9, 2023

Codecov Report

Patch coverage has no change and project coverage change:-0.03%⚠️

Comparison is base(66aa7db) 95.52% compared to head(fdda28c) 95.50%.

Additional details and impacted files

@@            Coverage Diff             @@##           master     #212      +/-   ##==========================================- Coverage   95.52%   95.50%   -0.03%==========================================  Files          16       15       -1       Lines        1072     1067       -5     ==========================================- Hits         1024     1019       -5  Misses         48       48

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

per1234 added the enhancement label

Sep 9, 2023

Copy link

robertlipe commentedJul 18, 2025

I'm not a maintainer. This is just a fly-by comment.

Isn't thishttps://en.cppreference.com/w/cpp/string/basic_string/to_string.html
for the common case and
https://en.cppreference.com/w/cpp/utility/to_chars.html for the rest?

Adding new names for things that have been in the standard library for years just splits developer mindshare and increases maintenance burden. to_chars, unlike the warning in the code here, doesn't have the risk of buffer overruns.