Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Use itoa from samd core to replace use of deprecated sprintf call#211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jboynes wants to merge2 commits intoarduino:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
2 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
149 changes: 105 additions & 44 deletionstest/src/itoa.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,123 @@ | ||
| /* | ||
| Copyright (c) 2014 Arduino LLC. All right reserved. | ||
| This library is free software; you can redistribute it and/or | ||
| modify it under the terms of the GNU Lesser General Public | ||
| License as published by the Free Software Foundation; either | ||
| version 2.1 of the License, or (at your option) any later version. | ||
| This library is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. | ||
| See the GNU Lesser General Public License for more details. | ||
| You should have received a copy of the GNU Lesser General Public | ||
| License along with this library; if not, write to the Free Software | ||
| Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
| */ | ||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif | ||
| char* ltoa( long value, char *string, int radix ) | ||
| { | ||
| char tmp[33]; | ||
| char *tp = tmp; | ||
| unsigned long i; | ||
| unsigned long v; | ||
| int sign; | ||
| char *sp; | ||
| if ( string == nullptr ) | ||
| { | ||
| return nullptr ; | ||
| } | ||
| if (radix > 36 || radix <= 1) | ||
| { | ||
| return nullptr ; | ||
| } | ||
| sign = (radix == 10 && value < 0); | ||
| if (sign) | ||
| { | ||
| v = -value; | ||
| } | ||
| else | ||
| { | ||
| v = (unsigned long)value; | ||
| } | ||
| while (v || tp == tmp) | ||
| { | ||
| i = v % radix; | ||
| v = v / radix; | ||
| if (i < 10) | ||
| *tp++ = static_cast<char>(i+'0'); | ||
| else | ||
| *tp++ = static_cast<char>(i + 'a' - 10); | ||
| } | ||
| sp = string; | ||
| if (sign) | ||
| *sp++ = '-'; | ||
| while (tp > tmp) | ||
| *sp++ = *--tp; | ||
| *sp = 0; | ||
| return string; | ||
| } | ||
| char* ultoa( unsignedlong value, char *string, int radix) | ||
| { | ||
| char tmp[33]; | ||
| char *tp = tmp; | ||
| unsigned long i; | ||
| unsigned long v = value; | ||
| char *sp; | ||
| if ( string == nullptr ) | ||
| { | ||
| return nullptr; | ||
| } | ||
| if (radix > 36 || radix <= 1) | ||
| { | ||
| return nullptr; | ||
| } | ||
| while (v || tp == tmp) | ||
| { | ||
| i = v % radix; | ||
| v = v / radix; | ||
| if (i < 10) | ||
| *tp++ = static_cast<char>(i+'0'); | ||
| else | ||
| *tp++ = static_cast<char>(i + 'a' - 10); | ||
| } | ||
| sp = string; | ||
| while (tp > tmp) | ||
| *sp++ = *--tp; | ||
| *sp = 0; | ||
| return string; | ||
| } | ||
| char* itoa( intvalue, char *string, int radix) | ||
| { | ||
| return ltoa( value, string, radix ) ; | ||
| } | ||
| char* utoa(unsignedint value, char *string, int radix) | ||
| { | ||
| return ultoa( value, string, radix ) ; | ||
| } | ||
| #ifdef __cplusplus | ||
| } // extern "C" | ||
| #endif |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.