Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: add test case for CanMsgRingBuffer.#207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 1 commit intoarduino:masterfromjboynes:fix_canmsg_volatile
Sep 8, 2023

Conversation

jboynes
Copy link
Contributor

Fixes a deprecated use of volatile in CanMsgRingbuffer.
Also added a basic testcase to make sure the CPP file is compiled/tested.

Relies on PR#206 to reliably run the tests under C++20

@codecov-commenter
Copy link

codecov-commenter commentedSep 7, 2023•
edited
Loading

Codecov Report

Patch coverage:100.00% and project coverage change:-0.09%⚠️

Comparison is base(ebe1fab) 95.61% compared to head(1765628) 95.52%.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #207      +/-   ##==========================================- Coverage   95.61%   95.52%   -0.09%==========================================  Files          14       16       +2       Lines        1048     1072      +24     ==========================================+ Hits         1002     1024      +22- Misses         46       48       +2
Files ChangedCoverage Δ
api/CanMsgRingbuffer.cpp89.47% <100.00%> (ø)

... and2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report?Share it here.

@per1234per1234 added the bug labelSep 7, 2023
@aentingeraentinger changed the titleFix CanMsgRingbuffer volatileFix: add test case for CanMsgRingBuffer.Sep 8, 2023
Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't see any change pertainingvolatile (unless you refer to the change of unary increment/decrement operators to a binary arithmetic operation), but I do appreciate adding the test case.

@aentingeraentinger merged commitf77c4b5 intoarduino:masterSep 8, 2023
@jboynesjboynes deleted the fix_canmsg_volatile branchSeptember 8, 2023 07:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aentingeraentingeraentinger approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jboynes@codecov-commenter@aentinger@per1234
[8]ページ先頭
©2009-2025 Movatter.jp