Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test to ascii#206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 1 commit intoarduino:masterfromjboynes:test_toAscii
Sep 8, 2023
Merged

Test to ascii#206

aentinger merged 1 commit intoarduino:masterfromjboynes:test_toAscii
Sep 8, 2023

Conversation

jboynes
Copy link
Contributor

Fix for#197 by removing undef of _GNU_SOURCE.
Change includes PR#205 so I can run the test suite reliably.

@codecov-commenter
Copy link

codecov-commenter commentedSep 7, 2023•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (e9d4d01) to head (1e6d3f1).
⚠️ Report is 48 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #206   +/-   ##=======================================  Coverage   95.61%   95.61%           =======================================  Files          14       14             Lines        1048     1048           =======================================  Hits         1002     1002             Misses         46       46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@per1234per1234 linked an issueSep 7, 2023 that may beclosed by this pull request
@per1234per1234 added the bug labelSep 7, 2023
Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

Compiling of the test cases under C++20 is not terribly relevant to us, but since it also works w/ C++11 (under which our CI tests run) AND because its test code I'll allow this in.

@aentingeraentinger merged commitebe1fab intoarduino:masterSep 8, 2023
@jboynesjboynes deleted the test_toAscii branchSeptember 8, 2023 07:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@aentingeraentingeraentinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error compiling test_toAscii.cpp with higher language level

4 participants

@jboynes@codecov-commenter@aentinger@per1234
[8]ページ先頭
©2009-2025 Movatter.jp