Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Do not rely on the actual value returned from strcmp in tests, only the sign.#205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aentinger merged 1 commit intoarduino:masterfromjboynes:test_compareTo
Sep 8, 2023

Conversation

jboynes
Copy link
Contributor

Fix for issue#204 where the test suite fails intermittently on some platforms.

@aentinger
Copy link
Contributor

That's a good one, thank you for the fix. I'll check tomorrow if the new test cases make semantic sense too.

@jboynesjboynes mentioned this pull requestSep 7, 2023
@per1234per1234 linked an issueSep 7, 2023 that may beclosed by this pull request
@per1234per1234 added the bug labelSep 7, 2023
Copy link
Contributor

@aentingeraentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍 though the test cases themselves may need an overhaul, they are not very expressive.

@aentingeraentinger merged commite9d4d01 intoarduino:masterSep 8, 2023
@jboynesjboynes deleted the test_compareTo branchSeptember 8, 2023 07:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aentingeraentingeraentinger approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent failure with test case String::compareTo(const char *)
3 participants
@jboynes@aentinger@per1234
[8]ページ先頭
©2009-2025 Movatter.jp