isAscii: avoid dependency on _GNU_SOURCE#176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

facchinm merged 5 commits intomasterfrompatch_isascii

Dec 21, 2022

Merged

isAscii: avoid dependency on _GNU_SOURCE#176

facchinm merged 5 commits intomasterfrompatch_isascii

Dec 21, 2022

Conversation

Copy link

Member

facchinm commentedDec 20, 2022•
edited
Loading

@DhruvaG2000
@beriberikix
@carlosperate
@matthijskooijman

facchinm added3 commits

December 20, 2022 17:25

catch: update to 2.13.9

c6ca793

Add testcases for isAscii

ffc4b00

isAscii: avoid dependency on _GNU_SOURCE

1171abb

Fixes#158Thanks to@kenny5660 for the one liner

Copy link

codecov-commenter commentedDec 20, 2022•
edited
Loading

Codecov Report

Base:96.11% // Head:96.20% // Increases project coverage by+0.08% 🎉

Coverage data is based on head(981a9f6) compared to base(c8ee90f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@##           master     #176      +/-   ##==========================================+ Coverage   96.11%   96.20%   +0.08%==========================================  Files          13       13                Lines         953      949       -4     ==========================================- Hits          916      913       -3+ Misses         37       36       -1

Impacted Files	Coverage Δ
api/WCharacter.h	`100.00% <100.00%> (ø)`
api/Print.cpp	`95.20% <0.00%> (-0.03%)`	⬇️
api/Stream.cpp	`91.42% <0.00%> (+0.39%)`	⬆️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

Copy link

carlosperate commentedDec 20, 2022

Thanks for the PR@facchinm!

I haven't test it yet, but doesn't it also need an custom implementation oftoascii(), as used intoAscii()?

ArduinoCore-API/api/WCharacter.h

Lines 144 to 150 ine26862e

	// Converts c to a 7-bit unsigned char value that fits into the
	// ASCII character set, by clearing the high-order bits.
	inlineinttoAscii(int c)
	{
	returntoascii (c);
	}