Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Add IPv6 support to IPAddress#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedAug 14, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
codecov-commenter commentedAug 14, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #169 +/- ##==========================================+ Coverage 96.00% 96.11% +0.10%========================================== Files 13 13 Lines 827 953 +126 ==========================================+ Hits 794 916 +122- Misses 33 37 +4
Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@sgryphon 🚀 Great work! Also thank you for adding all those test cases! I believe the size increase from 4 to 20 Bytes is an acceptable tradeoff for adding support for IPv6.
Uh oh!
There was an error while loading.Please reload this page.
Some suggested code to add support for IPv6 to the IPAddress class. (Issue#168 )
The public interface changes are minimal:
The changes are backward compatible. All of the IPv4 test cases continue to pass without any changes. i.e. Any IPv4 code will continue to get the same outputs for a given inputs.
Test cases added to cover IPv6.
Note: Whilst backwards compatible, this change does increase the memory footprint from 4 bytes to 20 bytes (assuming the enum compiles as an underlying int32_t, I think).