Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding MacAddress, MacAddress8#162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mrengineer7777 wants to merge2 commits intoarduino:master
base:master
Choose a base branch
Loading
frommrengineer7777:mrengineer7777-MacAddress

Conversation

mrengineer7777
Copy link

@mrengineer7777mrengineer7777 commentedMay 3, 2022
edited
Loading

Adding New Classes MacAddress, MacAddress8 in the style of IPAddress. Note I didn't include Printable, as I don't understand how that works (edit: see updates below). If someone else wants to add it later, they are welcome to do so. This is my first time contributing to this repository, so please feel free to point out any mistakes.

This library originated on arduino-esp32 (espressif/arduino-esp32#6667). It was suggested that I contribute to the Arduino core as well :)

Adding New Classes MacAddress, MacAddress8 in the style of IPAddress.  Note I didn't include Printable, as I don't understand how that works.  If someone else wants to add it later, they are welcome to do so.  This is my first time contributing to this repository, so please feel free to point out any mistakes.This library originated on arduino-esp32 (espressif/arduino-esp32#6667).  It was suggested that I contribute to the Arduino core as well :)
@CLAassistant
Copy link

CLAassistant commentedMay 3, 2022
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commentedMay 3, 2022
edited
Loading

Codecov Report

Merging#162 (a740b1c) intomaster (e03b653) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master     #162   +/-   ##=======================================  Coverage   96.00%   96.00%           =======================================  Files          13       13             Lines         827      827           =======================================  Hits          794      794             Misses         33       33

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee03b653...a740b1c. Read thecomment docs.

Added printTo().  Added index operators and type converters.  See test project here:https://github.com/mrengineer7777/MA_Test.  No further changes expected.
@mrengineer7777
Copy link
Author

Final version, ready for review. See test project here:https://github.com/mrengineer7777/MA_Test

@mrengineer7777
Copy link
Author

It seems there is no interest so I will be deleting this PR soon.

@aentinger
Copy link
Contributor

Sorry, this fell through the cracks. In any case adding test code would be much appreciated.

@facchinm what do you think re integrating this to the core API?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mrengineer7777@CLAassistant@codecov-commenter@aentinger

[8]ページ先頭

©2009-2025 Movatter.jp