Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Add a new 'OUTPUT_OPENDRAIN' pinmode for platforms.#157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedSep 22, 2021
Codecov Report
@@ Coverage Diff @@## master #157 +/- ##======================================= Coverage 96.00% 96.00% ======================================= Files 13 13 Lines 827 827 ======================================= Hits 794 794 Misses 33 33
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading.Please reload this page.
Not every MCU offers open drain pins, but some do. This changemeans that they'll no longer have to play games to implement anAPI-compatible pinMode() function that offers open drain.Fixesarduino#155If you're reading this commit message because you need to add anotherpin mode to this enum, the hacky trivial workaround is to do somethinglike this in your core:```// This typedef is used to extend the PinMode typedef enum// in the ArduinoAPI, since they don't have contantstypedef enum { INPUT_ANALOG = 99 , // We assume that the Arduino core will never have 99 PinModes OUTPUT_OPEN_DRAIN // It'd be cleaner to be able to count the size of that enum} PinModeExtension;```Because PinMode is an enum and not a proper type, the compiler willlet the user pass either a PinMode or a PinModeExtension to yourpinMode() function, even though the signature is`void pinMode(pin_size_t ulPin, PinMode ulMode)`
Not every MCU offers open drain pins, but some do. This change
means that they'll no longer have to play games to implement an
API-compatible pinMode() function that offers open drain.
Fixes#155
If you're reading this commit message because you need to add another
pin mode to this enum, the hacky trivial workaround is to do something
like this in your core:
Because PinMode is an enum and not a proper type, the compiler will
let the user pass either a PinMode or a PinModeExtension to your
pinMode() function, even though the signature is
void pinMode(pin_size_t ulPin, PinMode ulMode)