Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a new 'OUTPUT_OPENDRAIN' pinmode for platforms.#157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
facchinm merged 1 commit intoarduino:masterfromobra:master
Oct 1, 2021

Conversation

obra
Copy link
Contributor

Not every MCU offers open drain pins, but some do. This change
means that they'll no longer have to play games to implement an
API-compatible pinMode() function that offers open drain.

Fixes#155

If you're reading this commit message because you need to add another
pin mode to this enum, the hacky trivial workaround is to do something
like this in your core:

// This typedef is used to extend the PinMode typedef enum// in the ArduinoAPI, since they don't have contantstypedef enum {        INPUT_ANALOG = 99 , // We assume that the Arduino core will never have 99 PinModes        OUTPUT_OPEN_DRAIN   // It'd be cleaner to be able to count the size of that enum} PinModeExtension;

Because PinMode is an enum and not a proper type, the compiler will
let the user pass either a PinMode or a PinModeExtension to your
pinMode() function, even though the signature is
void pinMode(pin_size_t ulPin, PinMode ulMode)

@codecov-commenter
Copy link

Codecov Report

Merging#157 (4270ce3) intomaster (6a524ad) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #157   +/-   ##=======================================  Coverage   96.00%   96.00%           =======================================  Files          13       13             Lines         827      827           =======================================  Hits          794      794             Misses         33       33
Impacted FilesCoverage Δ
api/Common.h100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6a524ad...4270ce3. Read thecomment docs.

Not every MCU offers open drain pins, but some do. This changemeans that they'll no longer have to play games to implement anAPI-compatible pinMode() function that offers open drain.Fixesarduino#155If you're reading this commit message because you need to add anotherpin mode to this enum, the hacky trivial workaround is to do somethinglike this in your core:```// This typedef is used to extend the PinMode typedef enum// in the ArduinoAPI, since they don't have contantstypedef enum {        INPUT_ANALOG = 99 , // We assume that the Arduino core will never have 99 PinModes        OUTPUT_OPEN_DRAIN   // It'd be cleaner to be able to count the size of that enum} PinModeExtension;```Because PinMode is an enum and not a proper type, the compiler willlet the user pass either a PinMode or a PinModeExtension to yourpinMode() function, even though the signature is`void pinMode(pin_size_t ulPin, PinMode ulMode)`
@facchinmfacchinm merged commite03b653 intoarduino:masterOct 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@facchinmfacchinmfacchinm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extending PinMode to support MCUs with open-drain outputs?
3 participants
@obra@codecov-commenter@facchinm

[8]ページ先頭

©2009-2025 Movatter.jp