Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork140
Fix bitWrite with parenthesis#154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Current version does not wrap arguments in "()", so works incorrectly when used like this:```bitWrite(var, bit, cond?1:0);```
CLAassistant commentedAug 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
aentinger commentedAug 30, 2021
Thank you for the PR 👍 However, we still need you to sign the CLA in order to merge this one. Please make sure to be signed in with the email you've used for the commit. |
positron96 commentedAug 30, 2021
Done it. You know, for a oneline fix this is a lot of stuff to do. |
aentinger commentedAug 30, 2021
Sorry, I didn't introduce the CLA stuff ... |
Current version does not wrap arguments in "()", so works incorrectly when used like this:
Fixes#153