Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Bool as return value for logical operations#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedMay 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@facchinm What do you reckon? Any undesirable side-effects you can think of? Looks good to me.
codecov-commenter commentedMay 25, 2021
Codecov Report
@@ Coverage Diff @@## master #147 +/- ##======================================= Coverage 96.04% 96.04% ======================================= Files 13 13 Lines 835 835 ======================================= Hits 802 802 Misses 33 33
Continue to review full report at Codecov.
|
It was rolled out to all ESP8266 users in that platform's3.0.0 release 9 days ago and I haven't seen any reports of problems from them. But I'm also not super tuned in to the ESP8266 community. |
@aentinger I can't see any undesirable side effect since the usual promotion/demotion automatic rules apply, I'm ok for merging it 😉 |
Good to go then. Can't think of any undesirable side-effects myself. |
ref.
esp8266/Arduino#7939
Make sure comments are correct and make it clear to the user that these only return either true or false, and not a numeric value.