Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork130
Fix: Allow HardwareI2C::requestFrom to return values > 256#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…he function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it.
codecov-io commentedDec 10, 2020
Codecov Report
@@ Coverage Diff @@## master #132 +/- ##======================================= Coverage 96.40% 96.40% ======================================= Files 14 14 Lines 835 835 ======================================= Hits 805 805 Misses 30 30 Continue to review full report at Codecov.
|
This was referencedDec 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Changing return type of
requestFromfromuint8_ttosize_tallows the function to return the correct amount of bytes read (since internally it's already asize_twhich is downcast to auint8_tupon returning it).Merging this PR also requires to merge
@facchinm Let's coordinate to get this done.