Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork137
Closed
Labels
Description
According to theshiftIn documentation the return parameter should bebyte. For symmetry with theshiftOut function it would make sense to returnuint8_t.
In this API the return value is currently specified aspin_size_t which can be eitheruint8_t oruint32_t
#ifdef EXTENDED_PIN_MODE// Platforms who wnat to declare more than 256 pins need to define EXTENDED_PIN_MODE globallytypedefuint32_tpin_size_t;#elsetypedefuint8_tpin_size_t;#endif
Suggest changing the declaration from:
pin_size_tshiftIn(pin_size_t dataPin,pin_size_t clockPin, BitOrder bitOrder);
to:
uint8_tshiftIn(pin_size_t dataPin,pin_size_t clockPin, BitOrder bitOrder);
Any reason not to do this?