Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7k
Include sketchbook folder and LibrarySettings.h#3757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
matthijskooijman commentedSep 1, 2015
@ArduinoBot build this please |
ffissore commentedSep 2, 2015
@ArduinoBot build this please |
ArduinoBot commentedSep 2, 2015
ffissore commentedSep 2, 2015
I guess it was sleeping... |
ffissore commentedSep 2, 2015
I have to put this on hold as I'm rewriting Compiler from scratch. We are internally testing it. More news will follow |
NicoHood commentedSep 2, 2015
Okay. If you rewrite the compiler please also consider PR#3697 which is also very important. |
PaulStoffregen commentedSep 2, 2015
Yikes! Please please please push this to a branch, or at least the nightly build for a while, before publishing in a full release. |
NicoHood commentedSep 17, 2015
I have another idea if you will implement this in the new compiler:
|
ffissore commentedNov 24, 2015
Assigning to@cmaglie. Also seearduino/arduino-builder#15 andarduino/arduino-builder#29 |
facchinm commentedSep 19, 2019
Closing this as the discussion about the metadata (or configuration) file is going to take place inarduino-cli repo and in the mailing list |
Test to improve#3717
Some notes to this PR:
This way you can place custom settings in this file. You can also add something like
#define LIBCONFIG_EXISTSto use custom settings or#ifndef SETTING. The reason why a specific filename is used is, that it will compile fine even if the file was not created by the user.You can also create custom settings like
MylibSetting.hand include it from the library. This makes the file required to exist. If not it will throw a compile error. If the file also exists in the library, the library file will be preferred (so you should use the Librarysettings.h instead for this usecase).Independent Issue found:
The deletion seems to be a general IDE issue. If you create a file and compile the sketch the file is copied to the build folder. If you delete the file again it wont be noticed and the sketchfolder still has this file. (The core has the same error,which is ignored).
I tried to delete the file after each compile. That worked fine till the point when LibrarySettings.h causes a compile error. The file wont be deleted then (in the build folder). If you delete it (in the IDE) its still in the build folder.
So this is a general, separate bug. Should I open a ticket for this?
May anyone build this to test it?