Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Boards Menu: add hint if core lives in sketchbook#10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cmaglie merged 3 commits intoarduino:masterfromfacchinm:label_core_in_sketchbook
Apr 27, 2020

Conversation

@facchinm
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other openPull Requests for the same update/change?

For core development the recommended methods is to clone the core repo in$sketchbook/hardware. Before9b48e8d these cores were listed after all Board Manager cores; now they are interleaved and quite difficult to spot immediately.
This patch adds the(sketchbook) label to cores living in sketchbook, usinggetAbsolutePath so symlinked cores can be spotted too).

@matthijskooijman
Copy link
Collaborator

Sounds like a good change. I've been modifying the platform.txt of these cores to change the label here, doing this automatically would be even better.

But I'm wondering if(sketchbook) is clear to users? I suspect a lot of users do not actually know the term sketchbook. People developing cores likely will, but there might also be people that have just followed some tutorial to install a core into their sketchbook and have no idea.

One alternative that springs to mind would be(manually installed) (as opposed to installed through board manager), but I'm not sure if that's really better (does not help finding the core files if needed).

Or how about(from sketchbook) (or(in sketchbook) or(installed in sketchbook))? That might make it clearer that this refers to the location of the core?

@facchinm
Copy link
MemberAuthor

(in sketchbook) sounds good, I'm amending the commit 😉

@facchinmfacchinmforce-pushed thelabel_core_in_sketchbook branch from6f5d097 to4c19878CompareApril 7, 2020 09:01
@matthijskooijman
Copy link
Collaborator

Hm, one more caveat: This now actually checks whether the absolute path is inside the sketchbook, but in my setup all my git checkouts live elsewhere and are symlinked into the sketchbook, so none of them show the(sketchbook) addition...

Would it make sense to, instead of looking at the path, keep a flag (or maybe a "source" field of "install dir/package dir/sketchbook") for each platform that is set when the platforms are loaded?

@facchinm
Copy link
MemberAuthor

Mine too are symlinked but I can see the label (they didn't show if I replacegetAbsolutePath withgetCanonicalPath in the subfolder check ). One alternative idea is to show the path (or a substring) if the sources are not in Arduino15 folder, which is unlikely to contain symlinks

@matthijskooijman
Copy link
Collaborator

Mine too are symlinked but I can see the label (they didn't show if I replace getAbsolutePath with getCanonicalPath in the subfolder check ).

Oh, good point. Let me doublecheck my setup and get back to you :-)

Co-Authored-By: Matthijs Kooijman <matthijs@stdin.nl>
@arduinoarduino deleted a comment fromArduinoBotApr 7, 2020
@arduinoarduino deleted a comment fromArduinoBotApr 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matthijskooijmanmatthijskooijmanmatthijskooijman left review comments

@cmagliecmaglieAwaiting requested review from cmaglie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.8.13

Development

Successfully merging this pull request may close these issues.

4 participants

@facchinm@matthijskooijman@ArduinoBot@cmaglie
[8]ページ先頭
©2009-2025 Movatter.jp