NotificationsYou must be signed in to change notification settings
Fork49
Star185

Add TTL option to Export#189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

b-gretsch wants to merge1 commit intoarangodb:devel

base:devel

Choose a base branch

fromb-gretsch:devel

Open

Add TTL option to Export#189

b-gretsch wants to merge1 commit intoarangodb:develfromb-gretsch:devel

Conversation

Copy link

b-gretsch commentedApr 1, 2016

For exports of big collections users may want to increase the cursor's TTL to a bigger value without having to change the server default.

Add TTL option to Export

8ebf813

Copy link

Contributor

tomterl commentedMay 2, 2016

If new functionality and grammar/spelling corrections are done, I prefer multiple commits, separating the different types of change.

Copy link

Contributor

frankmayer commentedFeb 10, 2017

@b-gretsch Thanks for this PR.
I would normally agree with@tomterl on this one, however, since this is a really old PR that slipped through, I think it's OK to let this one through without going through the separation process.

However there are a few more steps to get this merged:

Provide a test which uses this added functionality
Resolve conflicts.
Provide the ArangoDB company with a signed CLA, seehttps://github.com/arangodb/arangodb-php/blob/devel/CONTRIBUTING.md