- Notifications
You must be signed in to change notification settings - Fork49
Open
Description
arangodb-php/lib/ArangoDBClient/DocumentHandler.php
Lines 648 to 655 in54f7800
| if (isset($params[ConnectionOptions::OPTION_REPLACE_POLICY]) && | |
| $params[ConnectionOptions::OPTION_REPLACE_POLICY] === UpdatePolicy::ERROR | |
| ) { | |
| if (null !==$options['revision']) { | |
| $params['ignoreRevs'] =false; | |
| $headers['if-match'] ='"' .$options['revision'] .'"'; | |
| } | |
| } |
Line 651 may cause "Undefined index" Notice
'revision' option may not be set in$options param ofput. Docs ofreplace andreplaceById methods doesn't mention it should be provided. Instead it points out to Document's _rev.
So please consider (accordingly topatch method), to base the condition on something like:
$revision =$document->getRevision();if (null !==$revision) {...
or provide'revision' option/param withinreplace orreplaceById methods (ie. like it's done inremove)
The issue doesn't appears in < 3.5.0 , since in previous versionsincludeOptionsInParams inArangoDBClient/Handler returns empty array when its$options param is empty.
Condition result:
if (isset($params[ConnectionOptions::OPTION_REPLACE_POLICY]) &&$params[ConnectionOptions::OPTION_REPLACE_POLICY] === UpdatePolicy::ERROR )
is always false then
Metadata
Metadata
Assignees
Labels
No labels