Fuzzer: bad URL gives response [BTS-2178]#21866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

neunhoef wants to merge3 commits intodevel

base:devel

Choose a base branch

Open

Conversation

Copy link

Member

(Please describe the changes in this PR for reviewers, motivation, rationale -mandatory)

neunhoef added2 commits

Proper response if URL is bad.

1251948

This was discovered by the fuzzer. BTS-2178.

CHANGELOG.

2ee904d

neunhoef added this to thedevel milestone

cla-botbot added the cla-signed label

neunhoef self-assigned this

Fix another case.

c4a4ff3

jvolmer reviewed

		@@ -331,7 +331,8 @@ bool HttpCommTask<T>::readCallback(asio_ns::error_code ec) {

		err = llhttp_execute(&_parser, data, datasize);
		if (err != HPE_OK) {
		if (err == HPE_INVALID_HEADER_TOKEN) {
		if (err == HPE_INVALID_HEADER_TOKEN \|\| err == HPE_INVALID_URL \|\|
		err == HPE_UNEXPECTED_CONTENT_LENGTH) {
		_headerCorrupt = true;
		}